Merged
Conversation
- log warning instead of silently swallowing decode errors in consume iterators (client.py, async_client.py) - add threading.Lock for socket sends in FibpConnection to prevent interleaved frames from concurrent threads (fibp.py) - fix consume() docstring to drop false reconnect claim (client.py) - use asyncio.gather() in async enqueue_many for concurrent per-queue requests (async_client.py) - map FibpError via _map_enqueue_error_code in batch flush instead of wrapping as raw EnqueueError string (batcher.py) - use SSLContext.load_verify_locations(cadata=...) to avoid temp file for ca cert (fibp.py)
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 7 Cubic findings (3 P1, 4 P2) from PR #5
Summary by cubic
Fixes 7 Cubic findings (3 P1, 4 P2) by hardening FIBP networking, improving error propagation, and making async enqueues concurrent. Increases reliability under concurrency, surfaces decoding issues, and removes temp-file handling for CA certs.
Bug Fixes
FibpConnectionto prevent interleaved frames from concurrent threads (P1).FibpErrorvia_map_enqueue_error_codein batch flush for precise exceptions instead of a genericEnqueueErrorstring (P1).ClientandAsyncClient; skip bad frames and fix the inaccurateconsume()docstring (P2).SSLContext.load_verify_locations(cadata=...)to avoid temp files and related risks (P2).Performance
AsyncClient.enqueue_manysend per-queue requests concurrently withasyncio.gatherto improve enqueue throughput.Written for commit 4166053. Summary will update on new commits.